Repository navigation
Conversation
GitHub's ubuntu-24.04 thread job fails now and then on a report that XrdCl's poller thread frees a response buffer that a job thread copied before in XRootDMsgHandler::ParseResponse. Both stacks are inside the uninstrumented library, without eosmirror's code in them. Assisted-By: generative AI
Such a caller owns the directory that the test makes unreadable for nobody, so the test failed where it should skip. The comment and the docs said imprecisely which callers become nobody when they ask for it: every caller but a sudoer does, and a sudoer stays one. Assisted-By: generative AI
On an instance with a file's replicas on several storage nodes, the replica read may not show an append made during the read (3 of 3 runs on such an instance). The copy is then the listed version, and the next run copies the file again. docs/design.md records this. The test accepts that outcome only for a file whose replicas fileinfo puts on more than one host, so that the single-node test instance still catches a post-read check that misses changes. Assisted-By: generative AI
The comment on the sanitizer settings names what tsan.supp suppresses, and missed the report in XrdCl's response parsing added before. Assisted-By: generative AI
Contributor
Author
|
Claude Opus 5.5 (Claude Code, effort xhigh). The on-demand job ran for the first time, on this branch at 01e53db: run 41097365473. Both of its jobs passed. They covered the long tests (differential, crash consistency) and the integration tests against the container EOS instance and the xrootd server, without a sanitizer and under ASan/UBSan, including the sudoer's test. The PR's own CI passed on 01e53db as well. 416f100 only fixes a comment in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus 5.5 (Claude Code, effort xhigh), for Oliver.
Follow-up to #5: the problems that remained after its review and after runs on a multi-node EOS instance.
docs/design.md,tests/integration/test_eos.cc). Where a file's replicas are on several storage nodes, the replica read may not show an append made during the read. This is the append failure from Eos tests non root #5, reproduced on a multi-node instance. The copy is then the listed version, and the next run copies the file again. The test allows that outcome only for a file whose replicasfileinfoputs on more than one host.Tested
Not in this PR. Deleting
devand taking it out of the CI triggers waits for your go-ahead. The on-demand job (long and EOS integration tests) can run now thatmainhas the workflow. I'm starting it on this branch and will comment with the result.🤖 Generated with Claude Code
https://claude.ai/code/session_01TRxwa5YUZtSYaNrtTTkhun