feat(highwind): emit blobs conforming to the published results schema - #608
Merged
jaredlockhart merged 2 commits intoSep 28, 2026
Merged
Conversation
Because * Experimenter will load Highwind results against a shared schema in mozilla-nimbus-schemas. * Young experiments produced no blob, and the blob lacked per-branch values and run errors. This commit * Builds the blob from the HighwindAnalysis model, so a shape error fails before upload. * Emits every metric for every segment from day one, with per-branch values and the run's errors. Tracked by [EXP-7605](https://mozilla-hub.atlassian.net/browse/EXP-7605).
yashikakhurana
approved these changes
Sep 25, 2026
yashikakhurana
left a comment
There was a problem hiding this comment.
oh so more intact, error prones too, thank you @jaredlockhart this looks good to me
scholtzan
approved these changes
Sep 25, 2026
Comment on lines
+337
to
+339
| else sql_running.count_branch_units( | ||
| client, sql_generation.branch_units_query(cohort_table) | ||
| ) |
Contributor
There was a problem hiding this comment.
should this be wrapped in its own try, otherwise this failing may affect the already computed cells
Because * A failed unit-count query discarded every experiment's computed statistics This commit * Isolates the unit count so its failure is logged and branch units fall back to zero
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Tracked by EXP-7605.
Checklist for reviewer:
Commits should reference a bug or github issue, if relevant (if a bug is referenced, the pull request should include the bug number in the title)
Scan the PR and verify that no changes (particularly to
.circleci/config.yml) will cause environment variables (particularly credentials) to be exposed in test logsEnsure the container image will be using permissions granted to telemetry-airflow responsibly.