Repository navigation
Conversation
|
Example payload:
With
|
bhearsum
left a comment
There was a problem hiding this comment.
Before this is reviewed, it would be good to understand how the Gecko and/or Ship It side is going to work. This does look like it might work correctly for a manual ship_firefox run as part of off cycle repacks, because we can stick whatever we want in the parameters.
This doesn't look like it would help in the case where we have the following sequence of operations:
promote_firefoxruns, creating initial partner repacks- an off cycle partner repack is created
ship_firefoxis run via Ship It
In that situation, Ship It has no knowledge of the off cycle partner repack, and thus will not be able to put the appropriate information in the parameters.
It's also unclear to me if this will remove the need for the horrible hack of running and then cancelling a bunch of stuff (per https://bugzilla.mozilla.org/show_bug.cgi?id=1943594#c3) when running this just for an off cycle partner repack.
I'm not opposed to initially landing a fix just for the manual-ship_firefox-for-offcycle case, but I would prefer that we at least try to architect the full solution before implementing piecemeal fixes that might cause issues or need to be reverted to fix related issues.
…to-releases push-to-releases only copied partner repacks from the v1 partner build directory, so off-cycle partner respins (e.g. v202501231439) were silently excluded. Add an optional `partner_build_numbers` payload field mapping "partner/subpartner" to an integer >= 1. Partners missing from the map, or payloads without the field, keep using partner build number 1. Both the S3 and GCS push paths log the build number used for each partner and warn when a requested partner has no files under its candidates prefix.
915ce2b to
046346d
Compare
push-to-releases only copied partner repacks from the v1 partner build directory, so off-cycle partner respins (e.g. v202501231439) were silently excluded.
Add an optional
partner_build_numberspayload field mapping "partner/subpartner" to an integer >= 1. Partners missing from the map, or payloads without the field, keep using partner build number 1. Both the S3 and GCS push paths log the build number used for each partner and warn when a requested partner has no files under its candidates prefix.