Repository navigation
Conversation
Return the original pointer when a Rust pointee has zero size. Evaluate the pointer and offset in order so projected operand reads retain their checks.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the original pointer when
arith_offsethas a zero-sized Rust pointee. On the CBMC 6.11.0 SMT path, the old pointer addition can change the modeled address for an over-aligned ZST.Changes
Validation
Tested commit
cb10fb8on upstream mainc25a57bc.Related to #3589 and #4671.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.