Repository navigation
Add stopAllThreadsOnSuspend and steppingResumesAllThreads to launch.json schema - #1145
TEJA P C (PCTEJA) wants to merge 2 commits into
Conversation
…son schema Both options are honoured by debugpy (read in _set_debug_options for launch and attach sessions, each defaulting to true) but were missing from the debugpy launch/attach configuration schema, so VS Code flagged them as unknown properties in launch.json. Add both boolean options (default true) with documentation to the launch and attach schemas in package.json, and declare them on ICommonDebugArguments so they are typed for both request types. Fixes microsoft#1133
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree |
Tests (windows-2022, 3.11) failed before any test ran: pipx run nox died with ModuleNotFoundError: No module named 'pkg_resources' from the runner's cached pipx venv for nox. The same head passes that session on every other matrix cell, and sibling PRs pass windows-2022/3.11, so this is an empty commit to re-run the checks on a fresh runner. No code changes. Signed-off-by: TEJA P C <pcteja@users.noreply.github.com>
|
CI note: |
|
Follow-up: the workflows for the new head (f210ec2) are currently sitting at "action required" — they need a maintainer to approve the workflow runs before they start (I can't approve runs in this repo). Rich Chiodo (@rchiodo), when you get a chance, could you please approve the PR Validation run? Its |
|
Hi Rich Chiodo (@rchiodo), thanks for approving this PR, approving the workflow runs, and adding the label. Confirming the result on the latest head: Tests (windows-2022, 3.11) now passes, and every check is green, including Lint, VSIX, CodeQL, CLA, and Ensure Required Labels. The only remaining item is the VS Code PR Check, which is still pending. The earlier windows-2022 3.11 failure was the runner issue described above (nox failed to start with a pkg_resources error from the cached pipx venv), so the fresh run cleared it with no code changes. Thanks again for your help. |
Summary
Fixes #1133.
stopAllThreadsOnSuspendandsteppingResumesAllThreadsare honoured by debugpy but were missing from this extension's launch.json schema, so VS Code reported them as unknown properties.Support in debugpy: both options are read in
_set_debug_optionsin pydevd's JSON command handler for launch and attach sessions (steppingResumesAllThreadsviaargs.get("steppingResumesAllThreads", True);stopAllThreadsOnSuspendadded in microsoft/debugpy#2010), each defaulting totrue`. The extension's launch/attach resolvers pass configuration through to the debug adapter unfiltered, so declaring the options in the schema and types is sufficient for them to be documented and validated.Changes
package.json: addsteppingResumesAllThreadsandstopAllThreadsOnSuspend(boolean,default: true, with descriptions documenting the behaviour and defaults) to both thelaunchandattachconfigurationAttributesschemas.src/extension/types.ts: declare both options onICommonDebugArguments, which is shared by the launch and attach argument types.No other files need changes: comparable debugpy-consumed options follow the same schema-and-types pattern (for example `breakOnSystemExit), and resolver changes are not required for passthrough options.
Testing
package.jsonparses as valid JSON; both properties present in both schemas withdefault: true.npm run compile-tests(tsc) passes.eslintandprettier --checkpass onsrc/extension/types.ts.Note: the full VS Code test-host suite was not run locally (it requires downloading a VS Code build); CI will exercise it.
I have reviewed every changed line and take responsibility for it.