Repository navigation
Validate calendar dates in date and date-time formats - #375
Open
Michael Villari (mikevillari) wants to merge 1 commit into
Open
Michael Villari (mikevillari) wants to merge 1 commit into
Michael Villari (mikevillari) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dateanddate-timeformats currently accept impossible calendar dates, including2023-02-29and2023-04-31T12:00:00Z. Their regular expressions allow days through 31 without checking the month or leap year.Add a shared calendar check after the existing syntax check, following RFC 3339 section 5.7. Regression tests cover month boundaries, leap-year century rules, early years, timestamp offsets, and diagnostic messages and ranges.
Validation:
npm teston Node 22.23.2: compilation, all 5,352 tests, and all 9 lint checks pass. Both new regression tests fail before the fix.AI-assisted with Codex.