Repository navigation
Resolve percent-encoded fragments in JSON reference links - #370
Open
RKS (rksharma-owg) wants to merge 1 commit into
Open
RKS (rksharma-owg) wants to merge 1 commit into
RKS (rksharma-owg) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document links for references such as
#/$defs/foo%3Abardo not reach thefoo:bardefinition, even though current schema validation resolves it correctly. Link resolution matches the encoded text directly against property and anchor names.Decode the URI fragment once before resolving JSON Pointer tokens or anchors. Keep the URI before
#unchanged, including when the reference targets an embedded schema. Preserve the existing literal interpretation of malformed percent escapes so malformed input does not throw or break existing links.Tests:
npm teston Node 22.23.1 passes compilation, 5,356 tests and nine lint checks; untouched upstream passed 5,346 tests and nine lint checks.git diff --checkpasses.No public API or dependency changes. This fixes document-link navigation; it does not change schema-validation behavior. Fragment handling follows the URI representation of JSON Pointer described in RFC 6901 section 6.
Related to #281.
Prepared with Codex assistance; the validation above ran locally.