fix(reporter): keep other shards' blob reports in the output dir - #43035
Open
Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Open
Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Ashraf Ali (ashrafiucse) wants to merge 2 commits into
Conversation
Sharded blob runs share PLAYWRIGHT_BLOB_OUTPUT_DIR, but each run removed the whole dir before writing its own report, so every shard deleted the reports of previously completed shards. When sharded, only remove this shard's own output file now; non-sharded runs keep cleaning the dir. Fixes: microsoft#43013
A locked report file on Windows could make fs.promises.rm reject and fail the run; swallow the error like removeFolders does since the subsequent write truncates the file anyway. Fixes: microsoft#43013
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge-reportsthen only saw the last shard).config.shardis set, only remove this shard's own report file (best-effort with retries, likeremoveFolders); non-sharded runs keep cleaning the output dir as before.report.zip) now persists alongside new shard reports, since a sharded run only owns its own slot.Fixes #43013