Repository navigation
Repo: Update to Rust 1.95 - #3328
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Rust toolchain baseline to Rust 1.95 across workspace metadata, local dev environments, and CI pipeline bootstrap steps, aligning the build/CI toolchain with the upcoming release fork target.
Changes:
- Bump workspace
rust-versionto 1.95 (root workspace andxsyncworkspace). - Update Nix dev-shell Rust version to 1.95.0.
- Update Flowey/CI bootstrap toolchain references to 1.95.0 (GitHub Actions + ADO
ci-floweypipeline YAML).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Updates root workspace minimum supported Rust version to 1.95. |
xsync/Cargo.toml |
Updates xsync workspace minimum supported Rust version to 1.95. |
shell.nix |
Updates Nix shell Rust toolchain to 1.95.0. |
flowey/flowey_lib_hvlite/src/cfg_rustup_version.rs |
Updates Flowey’s central rustup toolchain version constant to 1.95.0. |
ci-flowey/openvmm-pr.yaml |
Updates ADO pipeline bootstrap rustup toolchain to 1.95.0. |
.github/workflows/openvmm-pr.yaml |
Updates GHA PR workflow rustup toolchain to 1.95.0. |
.github/workflows/openvmm-pr-release.yaml |
Updates GHA PR-release workflow rustup toolchain to 1.95.0. |
.github/workflows/openvmm-docs-pr.yaml |
Updates GHA docs PR workflow rustup toolchain to 1.95.0. |
.github/workflows/openvmm-docs-ci.yaml |
Updates GHA docs CI workflow rustup toolchain to 1.95.0. |
.github/workflows/openvmm-ci.yaml |
Updates GHA CI workflow rustup toolchain to 1.95.0. |
.github/workflows/copilot-setup-steps.yml |
Updates Copilot agent setup rustup toolchain to 1.95.0. |
| # Rust configuration — update this version manually when upgrading rustc | ||
| rustVersion = "1.94.0"; | ||
| rustVersion = "1.95.0"; | ||
|
|
||
| rust = pkgs.rust-bin.stable.${rustVersion}.default.override { |
There was a problem hiding this comment.
shell.nix hard-codes rustVersion rather than deriving it from the root Cargo.toml workspace.package.rust-version, but the Guide currently claims the Nix shell derives the Rust version from Cargo.toml and that rust-overlay is pinned. This mismatch can cause future version bumps to miss updating one source of truth or follow incorrect instructions; please either update the Guide to match the current behavior or change shell.nix to derive the version from Cargo.toml (and/or pin rust-overlay as documented).
There was a problem hiding this comment.
5019273
into
microsoft:main
This will likely be the version of Rust we take to our next release fork.
This will likely be the version of Rust we take to our next release fork.