fix: convert CSV fields above the parser limit - #2589
Open
KennySimpson (KennyMcSimpson) wants to merge 1 commit into
Open
KennySimpson (KennyMcSimpson) wants to merge 1 commit into
KennySimpson (KennyMcSimpson) wants to merge 1 commit into
Conversation
KennySimpson (KennyMcSimpson)
marked this pull request as ready for review
October 3, 2026 08:24
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CSV field longer than Python's parser limit currently makes
CsvConverterfail. Through the publicMarkItDownAPI, conversion then falls back to plain text, so a valid CSV loses its Markdown table. With the standard limit, this happens at 131,073 characters.Keep the existing limit for the first parsing attempt. If parsing raises
csv.Errorand the decoded input is longer than the current limit, retry with the limit bounded by the input length and restore the previous setting infinally. A module lock serializes CSV parsing across converter instances so their retries cannot overwrite each other's saved limit.csv.field_size_limitis process-wide. The lock coordinatesCsvConverterinstances only: unrelated CSV readers can observe the temporary limit, and independent changes to that setting are not synchronized.Validation
43 tests passed, including public API checks at the standard limit, one character above it, and a long Unicode field. They also check that the previous parser limit is restored.
Separate checks passed for custom limits, quoted multiline fields, and 36 concurrent public API conversions. The full multi-format test suite was not run.