Skip to content

Clarify IntegratedLearner sample requirements - #885

Open
0xMuluh wants to merge 7 commits into
develfrom
fix/817-integratedlearner-samples
Open

0xMuluh wants to merge 7 commits into
develfrom
fix/817-integratedlearner-samples

Conversation

@0xMuluh

@0xMuluh 0xMuluh commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • document complete-case and exact sample-name requirements
  • clarify that sampleMap does not impute or harmonize IntegratedLearner inputs
  • add a preflight sample-name validation example

Validation

  • git diff --check
  • affected R chunk parses successfully

Closes #817

@TuomasBorman TuomasBorman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really a requirement?

If it is so, IntegratedLearner should instead take the samples that are shared in all experiments, i.e., do something like this: https://github.com/microbiome/multiomics/blob/91318041e34f849fcdf4a639d1ed594d9c8e2b4b/R/utils.R#L466

I think it shouldn't block users to run the method.

@0xMuluh
0xMuluh requested a review from TuomasBorman October 15, 2026 07:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarification for IntegratedLearner preprocessing

2 participants