Repository navigation
Fix group chat behind proxy, spacing and deletion access - #2093
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group WebSockets compared the browser Origin with the internal request Host, rejecting valid connections behind a reverse proxy. Use the shared configured-origin validation while continuing to reject foreign origins.
Restore padding around the group chat toolbar (the old rule only matched header elements), keep composer controls separated, and remove nested padding from expandable cards. Expose owner-only Delete group directly on Members with confirmation, reusing existing deletion authorization and billing safeguards.
Validation: go test ./... -short, go vet ./..., Node group client tests and git diff --check pass. WebSocket regression covers configured public origin versus internal host, message delivery/reconnection through timing middleware, and foreign-origin rejection even with a spoofed forwarded host. Members-page tests cover owner/member deletion control visibility.
Browser visual verification remains unavailable: local Chromium launch is blocked by the environment's socket policy. Live deployment has not been verified.