[mrousavy]

Summary

• Read View props from the stable ShadowNode::getProps() owner instead of getConcreteSharedProps().
• Keep the static and const casts as separate, named shared_ptr values.
• Pass the resulting shared_ptr into ViewPropsHolderState by value and move it into storage.
• Keep the actual Props object shared and avoid an extra reference-count increment/decrement.

Root cause

React Native 0.79 through the current 0.87.0 declare getConcreteSharedProps() as returning const std::shared_ptr<...>&, but construct that reference from a temporary std::static_pointer_cast(...) result. Nitro's Android adopt() path then reads the dangling shared_ptr reference.

The new path starts from ShadowNode::getProps(), whose reference points to the stored owner, then casts the shared_ptr by value. Only the ownership handle is copied once; the Props object itself is not copied.

React Native compatibility

Nitro Views document React Native 0.78.0+ support. Official React Native source was audited for every released minor from 0.78.0 through the current stable 0.87.0:

• ShadowNode::getProps() has the same stable signature and returns the stored props_ member throughout the range.
• getConcreteSharedProps() does not exist in 0.78.
• getConcreteSharedProps() has the dangling-reference implementation in every release from 0.79 through 0.87.

Using getProps() therefore removes the lifetime bug and restores source compatibility with the documented 0.78 minimum. The repository's build and CI coverage is currently pinned to React Native 0.85.3.

Stacked on #1486 so Harness CI exercises the original descriptor refactor plus this isolated lifetime fix.

Validation

• clang-format --dry-run --Werror on both changed headers
• Generated Nitro View consumer compile for Android x86_64 on the repository's React Native 0.85.3
• ./gradlew :app:assembleDebug --no-daemon --console=plain -PreactNativeArchitectures=x86_64 -PnitroSanitizer=address
• Android Harness CI, including ASan: 528/528 tests passed

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
nitro-docs	Skipped		Aug 20, 2026 9:03am