Repository navigation
smite-ir: add LoadShortChannelId operation - #96
Merged
Merged
Conversation
LoadShortChannelId operation
devvaansh
force-pushed
the
load-short-channel-id
branch
3 times, most recently
from
May 24, 2026 20:19
259fe5e to
d5605a0
Compare
devvaansh
force-pushed
the
load-short-channel-id
branch
3 times, most recently
from
May 26, 2026 21:18
629a759 to
5c3b42f
Compare
morehouse
approved these changes
May 27, 2026
devvaansh
force-pushed
the
load-short-channel-id
branch
from
May 27, 2026 16:40
5c3b42f to
1876e6c
Compare
morehouse
reviewed
May 27, 2026
devvaansh
force-pushed
the
load-short-channel-id
branch
from
May 27, 2026 20:07
ca9ce89 to
2480e5b
Compare
morehouse
reviewed
May 27, 2026
Comment on lines
+142
to
+146
| VariableType::BlockHeight => self.append(Operation::LoadBlockHeight(rng.random()), &[]), | ||
| VariableType::Timestamp => self.append(Operation::LoadTimestamp(rng.random()), &[]), | ||
| VariableType::ShortChannelId => { | ||
| self.append(Operation::LoadShortChannelId(rng.random()), &[]) | ||
| } |
Member
There was a problem hiding this comment.
VariableType::ShortChannelId comes right after VariableType::ChannelId in the enum order, So I think we should preserve that ordering here as well
| @@ -1297,6 +1297,39 @@ fn param_mutator_changes_mined_num_blocks() { | |||
| ); | |||
| } | |||
Member
There was a problem hiding this comment.
nit: could also add LoadShortChannelId to the postcard_roundtrip tests as well
Comment on lines
+460
to
+461
| /// Interesting boundary values for the 16-bit SCID `output_index` component. | ||
| const INTERESTING_SCID_OUTPUT_INDEX: &[u16] = &[0, 1, u16::MAX / 2, u16::MAX - 1, u16::MAX]; |
Member
There was a problem hiding this comment.
This does not look very useful to me. Isn’t this already covered by INTERESTING_U16?
Collaborator
|
Please squash before merging. |
devvaansh
force-pushed
the
load-short-channel-id
branch
from
May 28, 2026 16:54
2b840cf to
10497b1
Compare
Contributor
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short channel IDs are needed for BOLT 7 gossip messages such as
channel_announcement and channel_update.
A short channel ID encodes the block height, transaction index, and
output index of the funding transaction as a packed u64.
Part of #71.