Repository navigation
smite-scenarios: convert execute fn into Executor struct - #117
Merged
Merged
Conversation
NishantBansal2003
force-pushed
the
executor-struct
branch
from
June 5, 2026 08:01
d65f690 to
e4629fa
Compare
ekzyis
approved these changes
Jun 5, 2026
ekzyis
left a comment
Contributor
There was a problem hiding this comment.
LGTM
nit: commit message mentions "owns the resources", but I think "borrow" is more accurate
|
|
||
| fn run(&mut self, input: &[u8]) -> ScenarioResult { | ||
| let start = std::time::Instant::now(); | ||
| let mut bitcoin_cli = self.target.bitcoin_cli().clone(); |
Contributor
There was a problem hiding this comment.
nit: could move this to where it's needed?
NishantBansal2003
force-pushed
the
executor-struct
branch
2 times, most recently
from
June 9, 2026 06:22
ff628b8 to
dc5480c
Compare
ekzyis
approved these changes
Jun 9, 2026
Contributor
There was a problem hiding this comment.
ACK dc5480c
CI failure looks unrelated, should work on force-push:
build (eclair)
ERROR: Error response from daemon: Get "https://registry-1.docker.io/v2/": context deadline exceeded
morehouse
reviewed
Jun 9, 2026
morehouse
reviewed
Jun 10, 2026
Move execution state into an Executor struct that encapsulates the state and handles required during program execution. This prepares for future changes that will add channel state to the executor, maintaining a ChannelId -> ChannelState mapping so IR operations can read and mutate channel-specific state throughout execution. Signed-off-by: Nishant Bansal <nishant.bansal.282003@gmail.com>
NishantBansal2003
force-pushed
the
executor-struct
branch
from
June 10, 2026 17:11
dcc237d to
70f12c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #111 (comment)
Move execution state into an
Executorstruct that owns the resources used during program execution. This prepares for future changes that will add channel state to the executor, maintaining aChannelId -> ChannelStatemapping so IR operations can read and mutate channel-specific state throughout execution.Now, during the funding flow, we can add a
ChannelStatefield that is populated duringBuildFundingCreatedand later used to verify the signature received inRecvFundingSigned(See: #103 (comment)).