Repository navigation
Conversation
Collaborator
|
Hi @fly1d, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Akka Contributors License Agreement: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #885.
After a multiline string, an invalid URL include on line 5 is reported as line 2.
ConfigParserbuilds semantic errors from a counter that only sees newline nodes, missing newlines embedded in quoted tokens.Use the offending include or field node's first positioned token for the error origin, falling back to the existing counter when no token has a location. This also handles preceding multiline keys, without changing tokenizer or value/object/array origins. Existing messages and causes are preserved.
Validation on macOS arm64:
test docpassed, with 607 tests and successful API documentation generation.ConfParserTestpasses all 46 tests.Related work in the Scala port: ekrich/sconfig#641. This PR is limited to the Java parser and its tests. Java 8 and Linux/Windows execution were not tested locally.