Repository navigation
Fix BugOrBroken resolving a delayed merge inside a concatenated list piece (#751) - #878
Open
kastoestoramadus wants to merge 2 commits into
Open
kastoestoramadus wants to merge 2 commits into
kastoestoramadus wants to merge 2 commits into
Conversation
…end#751) Resolving the issue lightbend#751 config crashes with BugOrBroken 'SimpleConfigObject.replaceChild did not find SimpleConfigList' when a duplicate key with a substitution (a delayed merge) sits inside a list that is a piece of a value concatenation. Add regression tests for the optional and the defined strict substitution variants. Co-Authored-By: GLM-5.3-Flash/effort not exposed through Claude Code <noreply@anthropic.com>
…htbend#751) Resolving a delayed merge inside a container that is a piece of a value concatenation threw BugOrBroken 'SimpleConfigObject.replaceChild did not find ...' (issues lightbend#751, also hit by lightbend#339's crash): the concatenation was never pushed onto ResolveSource's parent chain, so when the delayed merge replaced itself within its parent, the walk up the chain skipped the concatenation and tried to replace the container directly in its grandparent, where it cannot be found. ConfigConcatenation implements Container with working replaceChild and hasDescendant; resolveSubstitutions now pushes itself onto the source's parent chain like other containers do. Co-Authored-By: GLM-5.3-Flash/effort not exposed through Claude Code <noreply@anthropic.com>
kastoestoramadus
marked this pull request as ready for review
October 5, 2026 21:51
kastoestoramadus
marked this pull request as draft
October 5, 2026 21:52
Contributor
Author
|
TLDR: Superseded. The follow-up described here is no longer needed: #882 no longer has its own lookup view, so it does not conflict with this PR's |
Contributor
Author
|
TLDR: Stack of 5 drafts, #878 → #879 → #880 → #881 → #882; each branch contains the ones before it. They change the same resolver code, so a fix to a lower PR must be re-stacked into the ones above it: please do not rebase or force-push one branch alone. If the stack is hard to review, I can close them and open one combined draft from the head of #882 (each fix stays a test commit plus a fix commit). |
This was referenced Oct 6, 2026
kastoestoramadus
marked this pull request as ready for review
October 10, 2026 17:43
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: A duplicate key whose later value is a substitution, inside a list that is a piece of a concatenation, no longer throws
BugOrBroken: replaceChild did not find SimpleConfigList. Fixes #751.ConfigConcatenationwas missing from the substitution source's parent chain, so the delayed merge looked for its list one level too high. It now joins the chain like other containers.Two regression tests in
ConcatenationTestfail on main with that error.Generated with GLM-5.3-Flash/effort not exposed through Claude Code