Repository navigation
fix: align SD3 encoder token chunks before conditioning - #2111
Merged
Merged
Conversation
Owner
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix out-of-bounds token and weight slicing in SD3/SD3.5 conditioning when active encoders produce different numbers of 77-token chunks.
For example, CLIP-L and CLIP-G can produce 462 tokens while T5 produces 539. The conditioning loop processes seven chunks, reading past the end of both CLIP sequences on the seventh chunk.
Pad shorter active sequences with tokenizer-generated empty chunks before slicing. This preserves the full prompt, existing weights, and encoder-specific special tokens. Equal-length sequences remain unchanged.
Related Issue / Discussion
Related to #1105.
Additional Information
Checklist