Repository navigation
fix: MySQL 8.2+ and mysql:8 failing to start - #169
Merged
Merged
Conversation
✅ Deploy Preview for lando-acquia ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

MySQL 8.2 removed
expire_logs_days, but the recipe's MySQL 8 config still sets it, somysql:8.2,8.3and8.4abort on startup withunknown variable 'expire_logs_days=10'. The baremysql:8alias (MySQL 8.4.5) was also loading the 5.7 config file and failing onquery_cache_limit.expire_logs_days = 10withbinlog_expire_logs_seconds = 864000: same 10 days, supported since MySQL 8.0.1mysql:8to the MySQL 8 configexamples/acquia-mysql84onmysql:8to CIVerified locally on Lando 3.26.9:
lando startwithdatabase: mysql:8boots MySQL 8.4.5 with the MySQL 8 config andbinlog_expire_logs_seconds=864000.Same bug as lando/laravel#114.
Note
Medium Risk
Changes default database config selection and MySQL 8 server settings, which can affect any Acquia app using
mysql:8or 8.x images at startup.Overview
Fixes MySQL 8.2+ and
mysql:8startup failures in the Acquia recipe by aligning config selection and binlog settings with current MySQL behavior.In
config/mysql8.cnf,expire_logs_daysis replaced withbinlog_expire_logs_seconds = 864000(equivalent 10-day retention) so MySQL 8.2+ no longer errors on the removed variable. Inbuilders/acquia-base.js, the MySQL 8 config file is chosen when the version string starts with8(not only8.), so the baremysql:8alias getsmysql8.cnfinstead of the 5.7mysql.cnf.CI adds the
acquia-mysql84Leia example (database: mysql:8) and pinslando/run-leia-actionto1.0.0-beta.4. The changelog documents both fixes.Reviewed by Cursor Bugbot for commit 011e20b. Bugbot is set up for automated code reviews on this repo. Configure here.