Repository navigation
Avoid windows ASIO4ALL hang by using QueuedConnection - #3867
Conversation
|
I remember that we had the same kind of bug on iOS with the language switch a few years ago. |
This comment was marked as low quality.
This comment was marked as low quality.
I'd like to verify this on my PC with ASIO4ALL. What are the steps I should use to demonstrate the hang on existing versions? EDIT: ok, now seen the minimised AI comment above. I'll try changing devices within ASIO4ALL itself. |
|
You need to randomly enable/disable inputs/outputs in the ASIO4ALL gui and then sometimes click on the main window which will lead to a hang. It's not really reproducible but will come up quite quickly. |
|
My gut feel is this is because of Qt insisting on the GUI being the "main" thread. I guess the "proper" fix, from that perspective, is to start up CClient (and thus everything CClient looks after - CSound, CChannel, network bits, etc) on the real-time thread, leaving the "main" thread at normal priority. That should mean the only cross-thread calls are then between GUI and CClient... However, I guess that without substantial work, this might be the only way to fix it. Maybe it should have a guard so it's only Windows ASIO that gets it - unless there's reason to say it's needed for all platforms. |
|
Also note, could you check if the cherry pick on any commit is clean before merging and, if not, see why and say whether you'll deal with it. |
|
I would expect it to be a clean cherry pick. Yes, we could probably fix it by refactoring correctly but definitely not part of this Pr. |
Found by AI debugging: jamulussoftware#3779 (comment)
174a11e to
3d3c271
Compare
|
Merging. As there's nothing else tagged up pending backport, I'll cut the branch release. |
Short description of changes
I believe this fixes the hang on ASIO4ALL device switches - I cannot reproduce the hang anymore.
The AI proposed guard and the narrowed lock (#3862) doesn't seem to be needed - but might be worth implementing as lower prio fix.
CHANGELOG: Bug: Fix hang on Windows while changing devices in ASIO4ALL
Context: Fixes an issue?
Found by AI debugging:
#3779 (comment)
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for testing and review by someone else.
What is missing until this pull request can be merged?
Review and 2nd testing
Checklist