Repository navigation
Conversation
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
August 15, 2023 16:28
0fa5dfc to
ce91ced
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
4 times, most recently
from
August 28, 2023 12:28
ebbbb32 to
c3d913f
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
2 times, most recently
from
September 12, 2023 16:22
c9a93cb to
106b2e1
Compare
Member
|
iOS didn't experience that, I think. |
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
September 18, 2023 18:13
106b2e1 to
a35ba64
Compare
ann0see
reviewed
Sep 26, 2023
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
September 27, 2023 08:29
a35ba64 to
fc1d401
Compare
Member
|
iOS name is still saved; mute myself seems to be lost, but that could be another bug. I believe iOS was never affected. |
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
2 times, most recently
from
October 5, 2023 17:46
8c4a3a6 to
51ec4e6
Compare
ann0see
reviewed
Oct 14, 2023
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
3 times, most recently
from
October 15, 2023 12:56
6a0177f to
bb097c2
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
November 2, 2023 18:28
bb097c2 to
48eb7f1
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
December 9, 2023 11:07
48eb7f1 to
1e21d43
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
see #3206 |
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
December 14, 2023 17:57
1e21d43 to
f3cc155
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
January 14, 2024 10:23
f3cc155 to
ab0c5ae
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
2 times, most recently
from
February 18, 2024 11:41
5304008 to
4d87fbf
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
March 5, 2024 16:57
4d87fbf to
a3f976e
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
March 15, 2024 17:07
a3f976e to
0a031b0
Compare
softins
reviewed
Mar 26, 2024
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
March 26, 2024 17:16
0a031b0 to
9f876e0
Compare
pljones
force-pushed
the
bugfix/2395-save-settings-on-state-change
branch
from
March 26, 2024 21:12
9f876e0 to
1ebb55f
Compare
Member
|
As I said, I can't test on a real device. So I can't reliably test this. |
Member
|
Just built this on RPi and tried it out. Works fine. I noticed that it now saves |
Member
|
This change seems to break registration with a directory in GUI servers. See #3287 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
This change implements
applicationStateChangedandsaveStateRequestsignals to save settings.This mostly affects mobile platforms - it was identified on Android but may also affect iOS (untested).
CHANGELOG: Android: save settings on app state change
Context: Fixes an issue?
Fixes: #2395
Does this change need documentation? What needs to be documented and how?
This behaviour hasn't been documented, so no change needed.
Status of this Pull Request
Tested on Android 11 (Moto G9 Power retgb) (Qt5) - fixes the problem which existed in 3.10.0rc1
Tested on Linux (Qt6) - no noticable effect
What is missing until this pull request can be merged?
Checklist
I did see this but it appears unrelated...
and for the Windows Jack build:
AUTOBUILD: Please build all targets