Skip to content

Android - close buttons (chat and settings) - #1763 fix - #1876

Merged
ann0see merged 3 commits into
jamulussoftware:masterfrom
ngocdh:patch-3
Jun 15, 2021
Merged

ann0see merged 3 commits into
jamulussoftware:masterfrom
ngocdh:patch-3

Conversation

@ngocdh

@ngocdh ngocdh commented Jun 14, 2021

Copy link
Copy Markdown
Contributor

Fix for #1763: add close button for dialogs in Android.

Comment thread src/chatdlg.cpp Resolved
Comment thread src/clientsettingsdlg.cpp Resolved
@pljones pljones changed the title Android - chatdlg close button - #1763 fix Android - close buttons (chat and settings) - #1763 fix Jun 15, 2021
@ann0see

ann0see commented Jun 15, 2021 •

Copy link
Copy Markdown
Member

I don’t have an Android device at hand at the moment, but can anyone test it?

@pljones

pljones commented Jun 15, 2021 •

Copy link
Copy Markdown
Collaborator

Loaded up, connected, got feedback that didn't get detected, disconnected, checked in settings and feedback detection was enabled, closed settings using the menu. Checked Chat - closed using the menu okay.

(Android Moto G9 Power - the vertical sizing does need to be addressed still, my screen was too short.)

@ann0see ann0see left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. So happy to approve

@ann0see
ann0see merged commit 40c794d into jamulussoftware:master Jun 15, 2021
@ann0see

ann0see commented Jun 15, 2021

Copy link
Copy Markdown
Member

CHANGELOG: Add close button on Android to enhance UX

@hoffie hoffie added this to the Release 3.8.1 milestone Jun 15, 2021
@ngocdh

ngocdh commented Jun 16, 2021

Copy link
Copy Markdown
Contributor Author

Great thanks team :)

@ngocdh
ngocdh deleted the patch-3 branch June 16, 2021 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants