Repository navigation
fix: make qemu script runnable - #1098
Merged
ipetkov merged 1 commit intoNov 3, 2026
Merged
Conversation
In the cross-compilation example flake, `pkgs` has `crossSystem` set up for cross-compilation. This results in plain `pkgs.writeScriptBin` writing a binary for the host system. Since the point of the default app in this example is to run the cross-compiled binary using qemu, this should run on the build system, which is achieved by using `pkgs.pkgsBuildBuild`. Additionally, `writeScriptBin` does not add a shebang line. Using `writeShellScriptBin` instead fixes this problem and results in a runnable script that executes the binary using qemu on the build system.
Owner
|
Thanks for the fix! |
ipetkov
enabled auto-merge (squash)
November 3, 2026 01:32
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the cross-compilation example flake,
pkgshascrossSystemset up for cross-compilation. This results in plainpkgs.writeScriptBinwriting a binary for the host system. Since the point of the default app in this example is to run the cross-compiled binary using qemu, this should run on the build system, which is achieved by usingpkgs.pkgsBuildBuild. Additionally,writeScriptBindoes not add a shebang line. UsingwriteShellScriptBininstead fixes this problem and results in a runnable script that executes the binary using qemu on the build system.Checklist
docs/API.md(or general documentation) with changesCHANGELOG.md