Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
approved these changes
Oct 8, 2026
| const { matches: aMatches, ...aRest } = a; | ||
| const { matches: bMatches, ...bRest } = b; | ||
| return ( | ||
| shallowEqual(aRest, bRest) && |
Contributor
There was a problem hiding this comment.
Would it be better to check for length first so shallowEqual doesn't have to run if the easy length check fails?
Member
Author
There was a problem hiding this comment.
Sure, I guess. It's technically more correct, but the difference in order here can only ever be so little that it's negligible. Still, since it's more technically correct, I went ahead an changed the order: 159e920
| <ParamsReader tab={tab} /> | ||
| <IonRouterReader tab={tab} /> | ||
| <TestDescription> | ||
| Switch between Tabs A, B and C a few times. Hidden pages that read useParams should not re-render, and ones |
Contributor
There was a problem hiding this comment.
Thank you for adding why this page exists! Same for the rest.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31528
What is the current behavior?
Currently, every mounted view in an
IonRouterOutletre-renders on each navigation, hidden ones included. The view stack builds a newRouteContextvalue every time the outlet renders, which happens about 3 times per navigation, andNavManagerdoes the same withNavContextandIonRouterContext.What is the new behavior?
We now keep each view's
RouteContextvalue until its content changes, and a view whose route doesn't match the current location keeps the value it last rendered with. Hidden pages usinguseParamsno longer re-render, and the page being shown renders once when its match changes. TheNavManageralso only rebuilds its context values whenrouteInfochanges, souseIonRouterconsumers render once per navigation instead of twice.Does this introduce a breaking change?
Other information
The held value lives in a component under each view instead of on the view item, because two outlets with the same
idshare a view item while sitting under different parent routes.Hidden pages using
useNavigateoruseLocationstill render once per navigation, because React Router'suseNavigatereads the location internally. HoldingLocationContextwould fix that, butuseLocation()in a hidden page would then return a stale location, so I left that alone for now.Current dev build