Repository navigation
Preserve one-shot response bodies after validation - #483
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response validation enumerates the application response body to build the complete payload, then returns the same body object to the Rack server. Bodies backed by an IO, queue, or other one-shot enumerable are therefore empty when the server enumerates them again.
Buffer non-streaming response bodies selected for validation and use the buffered chunks for both schema validation and the returned Rack response. The original body is closed in an
ensureblock after it has been consumed. Responses that do not require validation and the existingstreaming_content_parserspath retain their current behavior.