Repository navigation
rust: bump bindgen to 0.72.1 for libclang 22 compatibility - #260
Merged
Merged
Conversation
The ubuntu-latest runner (Ubuntu 26.04) ships libclang 22, with which bindgen 0.69.5 treats the forward-referenced ___itt_track struct as opaque, failing the bindings-up-to-date test. bindgen 0.72.1 fixes this (rust-lang/rust-bindgen#3278). Regenerate the linux, macos and windows bindings for the new bindgen output format.
The generated bindings carry doc comments verbatim from the C headers, which trigger clippy::doc_markdown; they cannot be fixed by hand without breaking the bindings-up-to-date test.
bindgen 0.72 targets the rustc running it by default, which made the generated the output is reproducible and ittapi-sys keeps building with older compilers.
alexey-kireev
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ubuntu-latest runner moved to Ubuntu 26.04, which ships libclang 22. With it, bindgen 0.69.5 generates the forward-referenced ___itt_track struct as an empty placeholder, so test_ittnotify_bindings_up_to_date fails.
Bump bindgen to 0.72.1, which fixes that (rust-lang/rust-bindgen#3278), and regenerates the Linux, macOS and Windows bindings. bindgen's target Rust version is pinned to 1.70, so the output doesn't depend on the local rustc and ittapi-sys still builds with older compilers.
Also fix rust clippy warnings: allow clippy::doc_markdown, because the generated doc comments come straight from the C headers.