Skip to content

Fix compatibility with Robot Framework 7.5 - #29

Merged
Snooz82 merged 4 commits into
masterfrom
claude/issue-26-20261106-1124
Nov 9, 2026
Merged

Snooz82 merged 4 commits into
masterfrom
claude/issue-26-20261106-1124

Conversation

@mardukbp

@mardukbp mardukbp commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Fixes #26. RF 7.5 requires doc_format in LibraryDocBuilder and accepts it in TypeDocBuilder.build. Added backwards-compatible handling in RobotDebug/robotlib.py.

Generated with Claude Code

@claude

claude Bot commented Nov 6, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@mardukbp
mardukbp force-pushed the claude/issue-26-20261106-1124 branch 3 times, most recently from bf224b4 to dcd858a Compare November 9, 2026 13:13
@mardukbp

mardukbp commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

@claude The tests failed. Fix the problem

@claude

claude Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Claude finished @mardukbp's task in 35s —— View job


Fixed failing tests

  • Read CI logs
  • Fix the problem
  • Push

Cause: The CI failures came from TypeError: ResourceDocBuilder.__init__() missing 1 required positional argument: 'doc_format'. RF 7.5 requires doc_format for ResourceDocBuilder as well as LibraryDocBuilder. The earlier fix only covered LibraryDocBuilder.

Fix: ImportedResourceDocBuilder in RobotDebug/robotlib.py now has an __init__ that passes doc_format. It falls back to the no-argument call on RF < 7.5.

Verification: With RF 7.5.1 installed locally, I checked that both builders construct without error. I did not run the full test suite, so please confirm with the CI run on the new commit.
| Branch: claude/issue-26-20261106-1124

@mardukbp

mardukbp commented Nov 9, 2026

Copy link
Copy Markdown
Collaborator Author

@claude The tests failed. Fix the problem

@claude

claude Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Claude finished @mardukbp's task in 1m 20s —— View job


Fixed the failing acceptance tests

  • Read the CI logs for the "PR Testing" run on the last commit
  • Reproduce locally
  • Fix and push

Cause: The RF 7.5 fix was fine. All 26 unit tests passed in CI. The 33 failures were in the acceptance suite (tests/atest). Those tests ran the shell with Run Process ... stdin=<temp file>. When stdin is a regular file, prompt_toolkit prints "Input is not a terminal" and exits without reading any commands, so every shell assertion failed. The failure doesn't come from the RF 7.5 changes. Those tests were added in 49b533f, before any RF 7.5 change.

Fix:

  • tests/atest/DebugShell.py: replaced write_stdin_file with run_with_piped_stdin. It sends the script through a real pipe with subprocess.run(input=...) and still expands the <F8>-style key placeholders.
  • tests/atest/resources/shell.resource: Drive Shell now calls that keyword.

Verification: With RF 7.5.1 installed locally, the acceptance suite went from 33 of 42 failing to 42 of 42 passing. I did not run the unit tests or ruff locally because ruff isn't installed here. The change only touches test files, and CI's ruff step only checks RobotDebug and tasks.py. Please confirm with the CI run on the new commit.
| Branch: claude/issue-26-20261106-1124

@mardukbp
mardukbp force-pushed the claude/issue-26-20261106-1124 branch 5 times, most recently from f929152 to e70b662 Compare November 9, 2026 14:49
github-actions Bot and others added 4 commits November 9, 2026 16:00
LibraryDocBuilder now requires doc_format and TypeDocBuilder.build
accepts it too.

Co-authored-by: Marduk Bolaños <1140106+mardukbp@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Marduk Bolaños <1140106+mardukbp@users.noreply.github.com>

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Run Process with stdin=<file> makes prompt_toolkit exit immediately
without reading commands, so every shell test failed. Use a real pipe.

Co-authored-by: Marduk Bolaños <1140106+mardukbp@users.noreply.github.com>

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@mardukbp
mardukbp force-pushed the claude/issue-26-20261106-1124 branch from 0dd2a38 to d7efe09 Compare November 9, 2026 15:01
@Snooz82
Snooz82 merged commit c6d3c2d into master Nov 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

irobot doesn't work with RF 7.5

2 participants