Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/core/outlet_observer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,9 @@ export class OutletObserver implements AttributeObserverDelegate, SelectorObserv

private get dependentContexts() {
const identifiers = this.dependentControllerIdentifiers
return this.router.contexts.filter((context) => identifiers.includes(context.identifier))
return this.router.modules
.filter((module) => identifiers.includes(module.identifier))
.reduce((contexts, module) => contexts.concat(module.contexts), [] as Context[])
}

private hasOutlet(element: Element, outletName: string) {
Expand Down
17 changes: 17 additions & 0 deletions src/tests/modules/core/application_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,23 @@ export default class ApplicationTests extends ApplicationTestCase {
this.assert.ok(this.controllers[0] instanceof BController)
}

"test connecting controllers does not list the contexts of every controller"() {
const router = this.application.router
const contexts = Object.getOwnPropertyDescriptor(Object.getPrototypeOf(router), "contexts")!.get!
let contextsReads = 0
Object.defineProperty(router, "contexts", {
configurable: true,
get() {
contextsReads++
return contexts.call(this)
},
})

this.application.load(this.definitions)

this.assert.equal(contextsReads, 0)
}

get controllers() {
return this.application.controllers as LogController[]
}
Expand Down