Skip to content

fix: Mitigate the -L dependency= consolidation races on Windows under cc_common.link #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzbarsky merged 1 commit into from
Oct 5, 2026
Merged

fix: Mitigate the -L dependency= consolidation races on Windows under cc_common.link #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions util/process_wrapper/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ impl TemporaryDirectoryGuard {
/// Matching on what rustc can actually use within a given `-Ldependency=` directory
#[cfg(any(windows, test))]
const CRATE_SEARCH_ARTIFACT_EXTENSIONS: &[&str] =
&["rlib", "rmeta", "dll", "lib", "a", "so", "dylib"];
&["rlib", "rmeta", "dll", "lib", "so", "dylib"];

#[cfg(any(windows, test))]
fn is_crate_search_artifact(file_name: &str) -> bool {
Expand Down Expand Up @@ -540,6 +540,8 @@ mod test {
"foo.d",
"foo.rustc-output",
"noextension",
// The `.a` symlink to an rlib that `rules_rust` makes for `cc_common.link`.
"libfoo.a",
] {
assert!(
!is_crate_search_artifact(file_name),
Expand All @@ -559,7 +561,6 @@ mod test {
"foo.dll",
// Import library rustc emits alongside a Windows cdylib.
"foo.dll.lib",
"libfoo.a",
"FOO.RLIB",
] {
assert!(
Expand Down
Loading