Repository navigation
fix(evaluation): 详情加载失败可重试,防止旧预取覆盖当前状态 - #401
Open
brad0810wz-rgb wants to merge 2 commits into
Open
brad0810wz-rgb wants to merge 2 commits into
brad0810wz-rgb wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动
实验详情请求失败或记录不存在时,旧界面永久停在Loading:父组件丢弃异步结果、子组件await了void且没有设置error。
保留父子Promise结果和API错误;失败结束loading并显示Retry,重试可恢复。父缓存按实验ID请求代次隔离,离开详情/卸载及旧Failure Modes预取迟到时不覆盖当前状态。
Closes #396
截图
真实React EvaluationCenter及现有应用CSS,受控mock bridge产生可重复失败与成功,不含真实账户数据。
测试报告
Fork CI:4项全部成功。Ubuntu(ubuntu-latest)/ Bun1.4.2+744846f84,bun install --frozen-lockfile;每个job精确checkout
861a77d707f8a5b4e74e905523491ebad429cae8并断言HEAD。本地Windows / Bun1.4.4:
真实父子链覆盖双locale错误/无记录、Retry成功再进入Case、切换/卸载、Failure Modes预取→新失败→旧成功迟到;Case空值分支用真实CaseDetail受控父loader验证。没有替代详情组件。
主干本机沙箱全量2223 pass / 8 skip / 6环境fail(Bash2、本机HTTP3、固定C:/tmp路径1);前5项普通本机环境复核15 pass / 0 fail。完整Linux结果如上。
范围
3个生产文件、1个回归测试、3张截图;复用既有本地化错误和Retry文案,无新IPC协议。请求失效为逻辑隔离,不声称取消底层IPC执行。
组合兼容性验证
将这五项独立修复仅组合在测试提交
1f61746b7845794b966e22a61de7089370b486b5,未混入本PR。组合CI五项全部成功:Bun1.4.2 / Linux全量bun test --isolate→ 2296 pass / 9 skip / 0 fail;相关包聚焦 → 2156 pass / 9 skip / 0 fail;Windows相关回归 → 206 pass / 1 skip / 0 fail;类型检查(含longbridge-tools显式tsc)及secret scan通过。各job固定上述源码SHA并断言HEAD,保留测试退出码。详细命令和输出可在链接内对应job核对。