Repository navigation
fix: 历史研究按所选报告打开并绑定论点与变化对比 - #354
Open
kkinsen0314-alt wants to merge 1 commit into
Open
kkinsen0314-alt wants to merge 1 commit into
kkinsen0314-alt wants to merge 1 commit into
Conversation
This was referenced Oct 20, 2026
kkinsen0314-alt
marked this pull request as ready for review
November 4, 2026 11:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改动说明
Today 点击历史版本后,展示、保存论点和 What Changed 原先可能分别取到不同报告。本 PR 用持久化的
{symbol, reportId}贯通这些路径:sourceReportId经 converter/schema 与真实文件持久化保留;旧数据与 symbol-only 调用兼容。Closes #327
贡献由 Codex 辅助。未修改其他贡献者 PR,未请求额外审核。范围不包含 #331 全局工作台及 #326 手动论点复审。
测试报告
环境:macOS 13.0.1 / Apple Silicon arm64;Bun 1.4.2;Node 22.23.3;Electron 39.8.9;playwright-core 1.62.1。
详细报告:docs/research-report-selection-test-report.md。
远端 CI 状态
发布后已核验:PR 的 head 为
416f6712498ed36a45d87ade3fec73a351ef5369,与本地及本人 fork 分支一致;目标为helsome/folio:main,状态为待审查(Ready for review)。GitHub API 显示仓库的 PR checks 工作流为disabled_manually,该 head 当前无 workflow run 或 check。因此远端 CI 尚未执行,不能报告 CI 通过。未更改仓库工作流设置,也未触发 live / nightly / release 任务。基线、跳过及限制
038f20cf2d87e3575ffbe5469967bdf6ef960dc8的 KernelHost shared mock 缺 Yahoo provider 导出,独立原样基线已复现;补一行 mock 后原 17 项通过,未改 provider 行为。a-new与新版日期;修改后显示a-old与旧版日期。UI 截图
以下 9 张截图来自实际 Electron 正式构建与全新 profile,数据均为离线 fixture;验证脚本可复现。真实 preload / IPC / kernel / converter / repository 参与旧版论点落盘及进程重启验证;未调用真实 provider、付费模型或交易服务。不将 PNG、构建、profile 或原始日志提交到源码。
Before
Today 点击 A 旧版,却显示
a-new和 2026-10-18 日期(原样 main 基线)。After
同样操作显示
a-old和 2026-10-17 原始日期,明确说明没有对应 diff。历史、变化对比、保存、跨证券、重启与启动状态(7 张)
历史入口:A 两份报告、完整日期及当前版本标记。
What Changed:A 新版与直接前序 A 旧版对应。
旧版保存成功;真实 fixture 落盘的 sourceReportId 为 a-old。
切到 B:仅有 B 的报告与一条历史,不残留 A 结论。
实际 Electron 进程重启后:A 旧版内容、日期与选择仍正确。
真实输入/Enter 启动 B:已有历史时保留 Starting 状态,不显示 A 报告。
受控启动失败后:显示 B 历史报告与对应错误,操作可继续。
与其他 PR 的关系
#337 和 #345 均未合入本次基线,相关 reportId 传递存在重叠。本 PR 保留 #327 的独立范围,补齐异步失效、重启选择、精确缓存、来源落盘和分层回归/实际桌面证据;没有引入 #345 涉及的全局工作台或手动复审改动。