Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reviewing the boxpro code to see if I can find the reason for analog ghosting that seems to be happening for some people.
Boxpro code had this in AV_in_detect():
if (g_hw_stat.av_pal)
I2C_Write(ADDR_FPGA, 0x80, 0x10);
else
I2C_Write(ADDR_FPGA, 0x80, 0x00);
and g_hw_stat.av_pal being the address of an array the if-clause is always true. I guess the intention was to check g_hw_stat.av_pal_w?
AV_Mode_Switch_fpga() also executes dispw -s command, so in addition just doing I2C_Write could result in an inconsistent display config?
Fixed the same bug in the logging.