Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatchReaderassumes oneReadfills its header buffer. A valid PNG or JPEG supplied throughiotest.OneByteReadertherefore returns unknown, while a three-byte ICO prefix is accepted after zero padding supplies a missing signature byte.Read at most 8192 bytes across short reads and pass only the received bytes to
Match. EOF after a short header is accepted; empty input now returnsErrEmptyBuffer, consistently withMatch. Other read errors propagate. The reader remains consumed; an unclosed stream may wait for the full prefix or EOF.Validation: the new fragmented-header, truncated-ICO, empty-input, read-limit and read-error regressions fail on current master. All tests pass with Go 1.16.15 and with Go 1.26.10 under the race detector (five repetitions, vet disabled). Formatting and
git diff --checkpass. Go 1.26 vet's existingsync.Mapcopy diagnostic infiletype.go:11was already reproduced on this unchanged master in the previous contribution; it is outside this patch. Hosted Go 1.19–1.21 CI has not run locally.