Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsMIMEstops at the first registered type with the requested MIME value, even when that type does not match the bytes. WOFF/WOFF2 and TTF/OTF share MIME values, so valid font headers can return false depending on registry iteration order.Continue checking types with the same MIME value until a matcher succeeds. Regression cases cover all four built-in font types and invalid input; the original implementation fails the WOFF2/TTF cases.
Validation: full Go 1.26.10 race suite and Go 1.16.15 suite pass; formatting and diff checks pass. Go 1.26
go vet ./...reports the existingTypessync.Map copy at filetype.go:11, identically on clean master and this branch. These are local header fixtures; no font rendering or deployment test is claimed.