Repository navigation
chore(bigtable): run samples tests pre-submit - #18599
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates relative imports across several Google Cloud Bigtable samples and adds new configuration files, including noxfile.py and requirements files, for the async data client samples. A critical issue was identified in packages/google-cloud-bigtable/samples/utils.py, where unresolved git merge conflict markers were left in the code, which will lead to a runtime SyntaxError.
daniel-sanche
added this pull request to stack #18600
October 7, 2026 23:48
daniel-sanche
force-pushed
the
samples_1_run_tests
branch
from
October 8, 2026 20:56
a062620 to
36b085c
Compare
daniel-sanche
marked this pull request as ready for review
October 9, 2026 01:04
parthea
force-pushed
the
samples_1_run_tests
branch
from
October 9, 2026 16:19
1cc22cd to
886ab68
Compare
Contributor
To clarify , I clicked the |
parthea
reviewed
Oct 9, 2026
parthea
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bigtable library lost the test configs for samples as part of the move to the monorepo, so they are left untested. This PR adds back the configs, and runs tests as part of the pre-submit check
Samples tests are now run from the central bigtable noxfile, instead of using individual noxfiles for each sample directory