Repository navigation
Fix comments, date format, and CLI description in add_app_campaign.py - #1107
Open
pattersonlois wants to merge 3 commits into
Open
pattersonlois wants to merge 3 commits into
pattersonlois wants to merge 3 commits into
Conversation
bobhancockg
requested changes
Nov 15, 2026
Author
|
Thanks @bobhancockg! Addressed both comments in 3443562:
|
bobhancockg
requested changes
Nov 16, 2026
Author
|
Thanks @bobhancockg! Addressed both comments in 7dce71c:
|
bobhancockg
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%Y-%m-%ddate format instart_date_timeandend_date_timeto match theCampaignproto specification, anchored to a singledatetime.now()call with explicittimedelta(days=...)units.create_ad_groupthatAPP_CAMPAIGNsupports audience signals (AdGroupCriterion.audience) rather than prohibiting all ad group criteria.ad_group_ad.ad.app_ad.imagesexample increate_app_adto construct anAdImageAssetmessage with a quoted"INSERT_AD_IMAGE_ASSET_RESOURCE_NAME_HERE"placeholder.ArgumentParserdescription (Adds an App campaign...).tests/examples/advanced_operations/add_app_campaign_test.py.