Repository navigation
Enable 2-line write prefetch in TCMalloc per-CPU slab Pop. - #1940
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_1021824224
branch
from
November 18, 2026 15:44
aec9c98 to
92e1369
Compare
Flip `TCMALLOC_INTERNAL_WRITE_PREFETCH` to 1 by default so `TcmallocSlab::Pop` prefetches up to the second cache line of the next object with write intent (`PrefetchWT0`). Switch the build and test variant to `no_write_prefetch` (`-DTCMALLOC_INTERNAL_WRITE_PREFETCH=0`) to keep the legacy single-line read-prefetch fallback covered, and update fast-path disassembly goldens. PiperOrigin-RevId: 1021824224
copybara-service
Bot
force-pushed
the
test_1021824224
branch
from
November 18, 2026 16:27
92e1369 to
28fd004
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable 2-line write prefetch in TCMalloc per-CPU slab Pop.
Flip
TCMALLOC_INTERNAL_WRITE_PREFETCHto 1 by default soTcmallocSlab::Popprefetches up to the second cache line of the next object with write intent (PrefetchWT0). Switch the build and test variant tono_write_prefetch(-DTCMALLOC_INTERNAL_WRITE_PREFETCH=0) to keep the legacy single-line read-prefetch fallback covered, and update fast-path disassembly goldens.