Repository navigation
chore(website): remove jinja human_link fallback and gonja dependency - #6343
Draft
michaelkedar wants to merge 1 commit into
Draft
michaelkedar wants to merge 1 commit into
michaelkedar wants to merge 1 commit into
Conversation
michaelkedar
force-pushed
the
human-link-drop-gonja
branch
from
November 11, 2026 03:15
707788d to
1f6e46d
Compare
michaelkedar
force-pushed
the
human-link-drop-gonja
branch
from
November 11, 2026 03:18
1f6e46d to
bef660c
Compare
michaelkedar
added a commit
that referenced
this pull request
Nov 11, 2026
Part 1/3 of moving `SourceRepository.human_link` off jinja (a leftover from the Python website) onto Go `text/template`. Templates get `.ID` and `.Ecosystems` (the affected ecosystems, in order), plus a small set of generic functions: - `field SEP N`: split on `SEP` and take part `N` (0-indexed; out of range is an error) - `replace OLD NEW` - `lower` Any render error means no human link is shown, so templates don't need conditionals. To keep things working while `source.yaml` is migrated (#6342), templates that fail to parse as Go templates fall back to gonja, with a `human_link is not a valid Go template, falling back to jinja` warning. The fallback is removed in #6343. Also updates the website devserver test data to the new syntax. Also removes the Flask-era `FLASK_SECRET_KEY`/`SECRET_KEY`/`API_URL` env var fallbacks from the website; neither staging nor prod sets them (both use `SESSION_SECRET_KEY`/`OSV_API_URL`). agy
All SourceRepository human_links are now Go templates, so remove the gonja fallback and the dependency.
michaelkedar
force-pushed
the
human-link-drop-gonja
branch
from
November 11, 2026 23:10
bef660c to
a9fcb39
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge until #6342 has been synced to Datastore in both projects and the
human_link is not a valid Go template, falling back to jinjawarning has stopped appearing in the website logs.Part 3/3: remove the jinja fallback from #6341 and the gonja dependency (plus its transitive dependencies).
agy