Repository navigation
Replace dead links in MediaType Javadoc with archived copies - #8876
Closed
farisbasha wants to merge 1 commit into
Closed
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The Adobe Flash video page, the Dart "embedding in HTML" article, the Browser Security Handbook page on content sniffing and the Native Client application structure guide no longer exist at their original URLs. Point them to Wayback Machine snapshots of the same pages, as is already done for `CACHE_MANIFEST_UTF_8`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several links in the
MediaTypeJavadoc now return 404 (or 500), so the "for more information" links on the published Javadoc lead nowhere:FLV_VIDEO: help.adobe.com ActionScript page (404)DART_UTF_8: dartlang.org "Embedding Dart in HTML" article (404)APPLICATION_BINARY: code.google.com/p/browsersec Part2 page (500, Google Code shut down)NACL_APPLICATION/NACL_PORTABLE_APPLICATION: developer.chrome.com Native Client "Application Structure" guide (404)This points each of them to a Wayback Machine snapshot of the same page, the same approach
CACHE_MANIFEST_UTF_8already uses in this file. I checked each snapshot loads and is the intended page (titles "Advanced topics for FLV files", "Embedding Dart in HTML", "Part2" with the "Survey of content sniffing behaviors" section, and "Application Structure" mentioningapplication/x-nacl/x-pnacl).Javadoc-only change in
guava/src; I left theandroid/copy alone since CONTRIBUTING says it is mirrored automatically.