Repository navigation
fix(integrations): keep daytona on the 0.x SDK DaytonaEnvironment uses - #8190
Open
mislavivanda wants to merge 1 commit into
Open
mislavivanda wants to merge 1 commit into
mislavivanda wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Daytona SDK 2.0 moves the 0.x API off the daytona package root into daytona.v0, so DaytonaEnvironment fails once 2.0 is the default install. Cap the daytona specifiers in the all, daytona and test extras at <1.
mislavivanda
force-pushed
the
fix/cap-daytona-below-1
branch
from
November 16, 2026 20:39
3edea6a to
2704a08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
2. Or, if no issue exists, describe the change:
Problem:
DaytonaEnvironmentis written against the 0.x Daytona SDK. It buildsCreateSandboxFromImageParams/CreateSandboxFromSnapshotParamsfrom thedaytonapackage root and callsAsyncDaytona.create(). Daytona SDK 2.0 keeps only the clients,DaytonaConfigand the errors at the root, and moves the 0.x API todaytona.v0(create()becomesAsyncDaytona().v0.create()).2.0.0 was briefly the default install on 2026-11-13. Daytona pulled it back and plans to make it the default again next week. The
all,daytonaandtestextras allowdaytona>=0.191with no upper bound, so after that a fresh install gets 2.0.0 and the integration fails. CI installs thetestextra the same way, so the Daytona unit tests would start failing too.Solution:
Cap the three specifiers at
daytona>=0.191,<1, the pin Daytona recommends for 0.x code. This keeps current users working. A later change can move the integration todaytona.v0withdaytona[v0-sdk]>=2,<3.Testing Plan
Unit Tests:
pytest tests/unittests/integrations/daytona: 21 passed with the capped range (resolves daytona 0.232.0). Withdaytona==2.0.0, the same module fails at import:The
pyproject-fmtandupdate-constraintspre-commit hooks pass. The constraints files already resolve daytona 0.198 to 0.220, so they don't change.Manual End-to-End (E2E) Tests:
N/A, dependency range change only.
Checklist