Skip to content

fix(integrations): keep daytona on the 0.x SDK DaytonaEnvironment uses - #8190

Open
mislavivanda wants to merge 1 commit into
google:mainfrom
mislavivanda:fix/cap-daytona-below-1
Open

mislavivanda wants to merge 1 commit into
google:mainfrom
mislavivanda:fix/cap-daytona-below-1

Conversation

@mislavivanda

Copy link
Copy Markdown

Link to Issue or Description of Change

2. Or, if no issue exists, describe the change:

Problem:
DaytonaEnvironment is written against the 0.x Daytona SDK. It builds CreateSandboxFromImageParams / CreateSandboxFromSnapshotParams from the daytona package root and calls AsyncDaytona.create(). Daytona SDK 2.0 keeps only the clients, DaytonaConfig and the errors at the root, and moves the 0.x API to daytona.v0 (create() becomes AsyncDaytona().v0.create()).

2.0.0 was briefly the default install on 2026-11-13. Daytona pulled it back and plans to make it the default again next week. The all, daytona and test extras allow daytona>=0.191 with no upper bound, so after that a fresh install gets 2.0.0 and the integration fails. CI installs the test extra the same way, so the Daytona unit tests would start failing too.

Solution:
Cap the three specifiers at daytona>=0.191,<1, the pin Daytona recommends for 0.x code. This keeps current users working. A later change can move the integration to daytona.v0 with daytona[v0-sdk]>=2,<3.

Testing Plan

Unit Tests:

  • I have added or updated unit tests for my change.
  • All unit tests pass locally.

pytest tests/unittests/integrations/daytona: 21 passed with the capped range (resolves daytona 0.232.0). With daytona==2.0.0, the same module fails at import:

ImportError: `CreateSandboxFromImageParams` is not exported from the `daytona` package root. Since SDK 2.0 the root holds only the clients (`Daytona`, `AsyncDaytona`), `DaytonaConfig` and the errors both API versions share, ...

The pyproject-fmt and update-constraints pre-commit hooks pass. The constraints files already resolve daytona 0.198 to 0.220, so they don't change.

Manual End-to-End (E2E) Tests:

N/A, dependency range change only.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

@google-cla

google-cla Bot commented Nov 16, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Daytona SDK 2.0 moves the 0.x API off the daytona package root into
daytona.v0, so DaytonaEnvironment fails once 2.0 is the default install.
Cap the daytona specifiers in the all, daytona and test extras at <1.
@mislavivanda
mislavivanda force-pushed the fix/cap-daytona-below-1 branch from 3edea6a to 2704a08 Compare November 16, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants