Repository navigation
Conversation
…in EnvironmentToolset instructions The lazy instruction builder used pathlib.PurePath(working_dir), which takes the host flavour: on Windows a sandbox path like /home/user became backslash-separated in the model prompt, and dirname of a bare relative directory was empty so the examples were relative to nothing. Render the documented POSIX path explicitly.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
EnvironmentToolsetbuilds the model-facing instruction lazily with the host path flavour:The tool always talks to a Linux sandbox, but
PurePathresolves against the running platform:PurePath("/home/user")renders as\home\user, so the prompt tells the model to start paths with a backslash-prefixed string the sandbox does not have;os.path.dirname()of a bare relative directory is"", so the examples are emitted relative to an empty directory;/home//user->/home/user), disagreeing with the directory that is actually created.The code already formats POSIX paths by hand a few lines below (
f"{working_dir}/{file_name}"), and the sandbox wrappers hard-code/workspace.Fix
Strip trailing separators and render the directory with
/, computing the parent directory on the POSIX string.Tests
tests/unittests/tools/test_environment_toolset.py(1 new test; the existing 21 still pass):