Repository navigation
chore: add CODEOWNERS - #121
Merged
Merged
Conversation
Routes all paths to the infra owners from godaddy/cli plus dclayton-godaddy. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
10 tasks done
qcai-godaddy
approved these changes
Oct 2, 2026
jpage-godaddy
added a commit
that referenced
this pull request
Oct 3, 2026
…olchain (#122) ## Summary - Fixes CI (failing on PR #121 with no Rust changes): newer stable rustc/clippy now flags `async_trait`'s generated `#[must_use]` as redundant (`clippy::double_must_use`) on 6 trait definitions, and flags one doc link in `config.rs` as having a redundant explicit target (`rustdoc::redundant_explicit_links`). Both are newly-stricter lints, not real regressions — fixed with scoped `#[allow]`s (plus a comment explaining why) and a doc-link simplification respectively. - Pins the toolchain via `rust-toolchain.toml` (the Rust equivalent of `.nvmrc` — `rustup` and `setup-rust-toolchain` both pick it up automatically, locally and in `ci.yml`/`release.yml`) so CI stops silently floating onto whatever `stable` happens to be that day. - Adds `.github/workflows/rust-toolchain-bump.yml`: a weekly (+ manually dispatchable) job that checks the real latest stable, and opens a PR bumping the pin when it's behind. That PR runs through the normal `ci.yml` checks, so if the new toolchain breaks something, a maintainer pushes fixes to that same branch before merging. - **Follow-up needed:** the bump PR is created with the default `GITHUB_TOKEN`, so GitHub's anti-recursion protection means it currently will *not* auto-trigger `ci.yml` (caught by Copilot review). The workflow's `create-pull-request` step now prefers a `RUST_TOOLCHAIN_BUMP_TOKEN` secret (PAT or GitHub App token) if one exists, falling back to `GITHUB_TOKEN` otherwise. Someone with repo-admin access needs to decide on and provision that secret for bump PRs to get real CI coverage; until then they'll need a manual push/re-run to trigger checks. - Skips the `Rust` CI job on PRs/pushes that don't touch Rust-relevant paths, via a `changes` job + job-level `if:` (not a trigger-level `paths:` filter) — `Rust` is a required status check on `main`, and a trigger-level path filter would leave that check stuck "Pending" forever on non-Rust PRs instead of satisfying it. A skipped job reports "Success" and doesn't block merge. - The `if:` fails *safe*: if the `changes` job itself fails (e.g. a `paths-filter` error) rather than cleanly resolving to `false`, the `Rust` job still runs instead of being skipped — otherwise a transient detection failure could let real Rust changes merge without ever running Rust CI (also caught by Copilot review). ## Test plan - [x] `cargo fmt --all --check` - [x] `cargo clippy --all-targets -- -D warnings` && `--features pkce-auth` - [x] `cargo test --all-targets` && `--features pkce-auth` (all passing) - [x] `cargo test --doc` && `--features pkce-auth` - [x] `RUSTDOCFLAGS='-D warnings' cargo doc --no-deps` && `--features pkce-auth` - [x] `cargo rustdoc --lib -- -W missing-docs` (0 missing) - [x] `./cli-engine/scripts/check-module-size.sh` - [x] `actionlint` on both workflow files - [x] Confirmed locally that `rustup` auto-switches to the pinned `1.99.0` toolchain on entering the repo - [x] Copilot review: 3 findings (fail-safe `if`, token-triggers-CI gap, a typo) addressed in a follow-up commit; re-review came back clean (0 findings) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/CODEOWNERSrouting all paths to the infra owners fromgodaddy/cli's fallback line, plusdclayton-godaddy.Test plan
🤖 Generated with Claude Code