Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric JSON-RPC request IDs can change when echoed in a response. If an ID cannot be decoded as an
int,RequestID.MarshalJSONfalls back tofloat32: for example,18446744073709551615becomes18446744000000000000, and9007199254740993e0becomes9007199000000000. Numbers outside the float32 range can become an empty string or zero. This breaks the JSON-RPC requirement to return the same ID value.Keep a private
json.Numberrepresentation for encoding numeric IDs. The existingInt,Float32, andStringconversions and zero-value behavior remain available. Regression tests cover large integers, decimal and exponent forms, accessor limits, reused IDs and input buffers, and actual HTTP success and error responses through each endpoint codec stage.Validation on source commit
09229de947a8459b72fffc8f1e7387503617a9f8:go testexit 1, with 27 failing leaf cases and 18 passing controls. The workflow succeeds only because it explicitly expects RED. The test file is byte-identical to this PR.-race -covermode=atomic -tags integration ./...suite withGOFLAGS=-mod=readonly. Each version has 280 top-level passes and the same five existing skips. JSON-RPC package vet and formatting checks pass.The original Eureka image uses Docker schema 1, so its default pull fails on the hosted runner's Docker 28.0.4. The environment proof records that failure, verifies the compatibility flag in the exact daemon version's source, and enables it only in the isolated runner. Baseline and final jobs use the same daemon binary and original pinned image digests, with real etcd, Consul, ZooKeeper, and Eureka readiness checks. This is a disclosed compatible environment, not proof that the default upstream CI environment succeeds. No dependency, CI, or service-image change is included in the PR.
Complete tracked-source HEAD, Git blob, SHA-256, and cleanliness snapshots are uploaded before and after native commands. Implementation and testing were assisted by AI; the change and native evidence were reviewed before submission.