Conversation
|
|
||
| /** Holds if arguments at position `apos` match parameters at position `ppos`. */ | ||
| pragma[inline] | ||
| predicate parameterMatch(ParameterPosition ppos, ArgumentPosition apos) { ppos = apos } |
| * idiom. | ||
| */ | ||
| pragma[inline] | ||
| predicate guardEnsures(Expr e, boolean b, BasicBlock bb) { e.(Guard).controls(bb, b) } |
owen-mc
force-pushed
the
go/shared-guards
branch
from
August 17, 2026 19:16
f8092fc to
57db4c8
Compare
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
owen-mc
force-pushed
the
go/shared-guards
branch
2 times, most recently
from
August 18, 2026 11:45
def5d61 to
888eae3
Compare
owen-mc
force-pushed
the
go/shared-guards
branch
from
September 20, 2026 22:01
888eae3 to
82e42b4
Compare
| private import semmle.go.dataflow.SSA as GoSsa | ||
| private import semmle.go.dataflow.SsaImpl as SsaImpl | ||
| private import codeql.controlflow.Guards as SharedGuards | ||
| private import codeql.controlflow.SuccessorType |
owen-mc
force-pushed
the
go/shared-guards
branch
from
September 22, 2026 15:40
c60e983 to
45fd28e
Compare
owen-mc
force-pushed
the
go/shared-guards
branch
from
September 30, 2026 22:46
17bf057 to
e3e1dcb
Compare
| )) | ||
| ) | ||
| or | ||
| caseExpressionBranch(this.(Expr), bb1, |
| Node g, ControlFlow::ConditionGuardNode guard, Node nd, SsaWithFields ap, P param | ||
| ) { | ||
| guards(g, guard, nd, param) and nd = ap.getAUse() | ||
| private predicate guards(Node g, Guard guard, GuardValue value, Node nd, SsaWithFields ap, P param) { |
| not exists(ControlFlow::ConditionGuardNode innerCond | | ||
| isDominatingLengthLEGuard(innerCond, index, array, bb) and | ||
| innerCond.getCondition().getParent+() = cond.getCondition() | ||
| not exists(Guard innerCond, boolean innerBranch | |
| ) and | ||
| // and it is not additionally guarded by a stronger index check | ||
| not exists(Index index2, int i, int i2 | | ||
| not exists(Index index2, int i, int i2, Guard g2, boolean b2 | |
| ) and | ||
| // and it is not additionally guarded by a stronger index check | ||
| not exists(Index index2, int i, int i2 | | ||
| not exists(Index index2, int i, int i2, Guard g2, boolean b2 | |
Add the complete guard regression suite and fold the shared hooks and Go-specific correctness fixes into the initial adapter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move simple data-flow and security consumers to shared guards, including value-aware barriers and the corrected feature-flag semantics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Explicitly implement the new optional SSA hooks in LogicInput_v3 so its signature members do not conflict with those imported from LogicInput_v2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
owen-mc
force-pushed
the
go/shared-guards
branch
from
October 1, 2026 13:53
e3e1dcb to
05e44c8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.