Repository navigation
fix: use medium thinking for Gemini 3.5 Flash - #142
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe client now applies medium thinking to translation and structured JSON requests for Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is identified; the change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Ref ENG-2096
What does this PR do?
Gemini 3.5 Flash sentiment, emotions, and translation requests now use medium thinking. Structured requests omit the legacy numeric thinking budget, while older models retain their existing zero-budget fallback. Temperature remains unchanged.
The change stays in the Google adapter. Rollout requires a new Hub image and coordinated web, taxonomy, and GitOps changes.
How should this be tested?
go test ./internal/googleai -run 'TestGemini35|TestCompleteJSON' -count=1covers real SDK serialization, EU routing, legacy fallback, and level-error handling.make test-unit,make build,make fmt, andmake lintpass; equivalent unit run included coverage.make testspasses against isolated PostgreSQL 18 with Hub and River migrations.The new Gemini tests fail against the base implementation. A synthetic Vertex EU smoke request accepted temperature 0 and medium thinking on both v1 and v1beta1; workflow quality/latency evaluation and staged deployment remain open.
Checklist
Required
make buildmake tests(integration tests intests/)make fmtandmake lint; no new warningsgit pull origin mainmigrations/with goose annotations and ranmake migrate-validateBranch starts from current main; no database or external API changes.
Appreciated
make testsor API contract workflow)docs/if changes were necessarymake tests-coveragefor meaningful logic changes