Repository navigation
Fix signs in floating-point duration formatting - #4981
Merged
Merged
Conversation
vitaut
approved these changes
Oct 24, 2026
Contributor
|
Merged, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negative floating durations repeat the minus sign with multiple chrono conversions, while negative infinity loses it. Reuse write_sign() in both paths to emit one leading minus, preserving precision, padding and positive/NaN behavior.
Both regression tests fail before the fix. All 22 test executables pass with GCC C++11, Clang C++20 and Windows MSVC C++20. Header-only probes, source formatting and diff checks pass. Windows uses the default warning policy; enabling WERROR additionally hits an unchanged GCC pragma.