Repository navigation
Conversation
vitaut
requested changes
Oct 8, 2026
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. Could the wide-character-specific code be moved to xchar.h? In particular, the new for_each_codepoint overload and wide-string formatting logic.
Contributor
|
Also the tests seem excessive for this change. Could you trim them down to focus on the actual fixes: Unicode width and precision, surrogate pairs, and debug escaping? In particular, the char8_t, range formatting, output iterator, and dynamic width tests don't seem necessary. |
Contributor
|
Do you plan to update this PR or shall we close it for now? |
vitaut
requested changes
Oct 17, 2026
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Looks like there are CI failures.
Contributor
|
Closing for now but feel free to reopen once CI issues are fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Unicode display width, precision and debug escaping for wide strings. UTF-16 surrogate pairs are decoded together; unpaired surrogates keep their individual escapes.
The wide-character codepoint traversal and string-formatting implementation now live in
xchar.h. Narrow-string formatting remains informat.h, with the existing escape scanner available to headers that do not includexchar.h.Tests focus on Unicode width and precision, surrogate pairs, and debug escaping. The extra char8_t, range, output-iterator and dynamic-width cases have been removed.
Validation with MSVC 19.44, x64, C++20 Debug: full CMake build passes and all 45 xchar tests pass. CTest passes 20 of 22 test programs;
chrono_test.localeandunicode_test.legacy_localefail with the Windows locale errors already recorded in the original validation. Changed code passes clang-format 20 andgit diff --check.