Repository navigation
chore(renovate): group lightmare crd-* image and chart bumps into one PR - #425
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open Renovate PRs #423 (crd-vm-api) and #424 (crd-admission) arrive one per image. Lightmare components ship as one release and the crd-operator chart carries the CRDs (
crds: CreateReplace), so an image bumped without its chart runs against the old schema; they should move together.This adds a
packageRulesentry grouping everycontainers.cloudless.dev/release/crd-*docker dependency (the four images and thecrd-operator-chartOCIRepository) undergroupName: lightmare.linstor-nic-syncdoes not match.separateMajorMinor: falsekeeps the group in one PR even when components (which version independently) cross different update types in the same release.After merge Renovate should replace #423/#424 with one "lightmare" group PR and autoclose the superseded ones.